laminelam commented on PR #1791:
URL: https://github.com/apache/solr/pull/1791#issuecomment-1718007335
@janhoy
I think it's good for a merge now.
THANK YOU again for all the time you spent on this, reviewing and
contributing.
--
This is an automated message from the Apache Git
laminelam commented on PR #1791:
URL: https://github.com/apache/solr/pull/1791#issuecomment-1706859388
> @laminelam Not much left on this now, do you need help with anything?
Hi @janhoy
Yes the only thing left is supporting http (in addition to https) for the
code hasher (sha256).
laminelam commented on PR #1791:
URL: https://github.com/apache/solr/pull/1791#issuecomment-1684023770
> Read through with some comments.
>
> A pity we don't have unit tests for frontend, cause there are some of this
which is hard to test, especially error cases.
>
> I have not
laminelam commented on PR #1791:
URL: https://github.com/apache/solr/pull/1791#issuecomment-1663529357
Hi @risdenk
As @janhoy is on vacation, can you please have another reviewer look at
this? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the me
laminelam commented on PR #1791:
URL: https://github.com/apache/solr/pull/1791#issuecomment-1642059052
> I think there are a bunch of `console.log` that could be `console.error`
if its an error or `console.debug` if its just debug logging.
Thanks @risdenk
Done (was following the e
