[GitHub] [solr] laminelam commented on pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-07-08 Thread GitBox
laminelam commented on PR #857: URL: https://github.com/apache/solr/pull/857#issuecomment-1179292325 Thank you @madrob and @HoustonPutman for your review. Pushed the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [solr] laminelam commented on pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-06-09 Thread GitBox
laminelam commented on PR #857: URL: https://github.com/apache/solr/pull/857#issuecomment-1151131277 Hi @HoustonPutman, as discussed, removed the acl package and added the ref guide, plus other minor changes. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [solr] laminelam commented on pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-06-02 Thread GitBox
laminelam commented on PR #857: URL: https://github.com/apache/solr/pull/857#issuecomment-1144887062 > I think we need to have a bigger discussion around backwards compatibility and how we achieve that. > > I would prefer to keep everything nice and neat, instead of spreading cl

[GitHub] [solr] laminelam commented on pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-05-13 Thread GitBox
laminelam commented on PR #857: URL: https://github.com/apache/solr/pull/857#issuecomment-1126493386 Thank you @madrob for your time reviewing this. I have pushed a new commit with code changes and left some answers to your comments. -- This is an automated message from the Apache Git