[GitHub] [solr] madrob commented on a change in pull request #267: SOLR-15595: Partial results from shard queries needlessly discarded for queries without sort fields

2021-08-25 Thread GitBox
madrob commented on a change in pull request #267: URL: https://github.com/apache/solr/pull/267#discussion_r696140459 ## File path: solr/core/src/test/org/apache/solr/handler/component/MockSortSpecBuilder.java ## @@ -0,0 +1,36 @@ +package org.apache.solr.handler.component;

[GitHub] [solr] madrob commented on a change in pull request #267: SOLR-15595: Partial results from shard queries needlessly discarded for queries without sort fields

2021-08-24 Thread GitBox
madrob commented on a change in pull request #267: URL: https://github.com/apache/solr/pull/267#discussion_r694909754 ## File path: solr/core/src/test/org/apache/solr/handler/component/QueryComponentPartialResultsTest.java ## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache

[GitHub] [solr] madrob commented on a change in pull request #267: SOLR-15595: Partial results from shard queries needlessly discarded for queries without sort fields

2021-08-20 Thread GitBox
madrob commented on a change in pull request #267: URL: https://github.com/apache/solr/pull/267#discussion_r693053694 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -955,9 +955,12 @@ protected void mergeIds(ResponseBuilder rb,