[GitHub] [solr] madrob commented on a diff in pull request #865: SOLR-16199: Improve handling of LIKE queries with wildcard

2022-05-18 Thread GitBox
madrob commented on code in PR #865: URL: https://github.com/apache/solr/pull/865#discussion_r876342658 ## solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrFilter.java: ## @@ -346,21 +346,52 @@ protected String translateAnd(RexNode node0) { } protected Strin

[GitHub] [solr] madrob commented on a diff in pull request #865: SOLR-16199: Improve handling of LIKE queries with wildcard

2022-05-18 Thread GitBox
madrob commented on code in PR #865: URL: https://github.com/apache/solr/pull/865#discussion_r875987015 ## solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrFilter.java: ## @@ -346,21 +346,52 @@ protected String translateAnd(RexNode node0) { } protected Strin

[GitHub] [solr] madrob commented on a diff in pull request #865: SOLR-16199: Improve handling of LIKE queries with wildcard

2022-05-18 Thread GitBox
madrob commented on code in PR #865: URL: https://github.com/apache/solr/pull/865#discussion_r875982767 ## solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java: ## @@ -2434,15 +2434,73 @@ public void testColIsNull() throws Exception { @Test public void

[GitHub] [solr] madrob commented on a diff in pull request #865: SOLR-16199: Improve handling of LIKE queries with wildcard

2022-05-17 Thread GitBox
madrob commented on code in PR #865: URL: https://github.com/apache/solr/pull/865#discussion_r875276783 ## solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrFilter.java: ## @@ -346,21 +346,52 @@ protected String translateAnd(RexNode node0) { } protected Strin

[GitHub] [solr] madrob commented on a diff in pull request #865: SOLR-16199: Improve handling of LIKE queries with wildcard

2022-05-17 Thread GitBox
madrob commented on code in PR #865: URL: https://github.com/apache/solr/pull/865#discussion_r875176213 ## solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrFilter.java: ## @@ -346,21 +346,52 @@ protected String translateAnd(RexNode node0) { } protected Strin