[GitHub] [solr] madrob commented on pull request #196: SOLR-15385 RawTypes Part V

2021-06-29 Thread GitBox
madrob commented on pull request #196: URL: https://github.com/apache/solr/pull/196#issuecomment-870027164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [solr] madrob commented on pull request #196: SOLR-15385 RawTypes Part V

2021-06-28 Thread GitBox
madrob commented on pull request #196: URL: https://github.com/apache/solr/pull/196#issuecomment-870059189 Also, I'd like to note that I'm totally fine with splitting this into whatever reviewable chunks you feel comfortable with, and I appreciate that you're saving us both time by going a

[GitHub] [solr] madrob commented on pull request #196: SOLR-15385 RawTypes Part V

2021-06-28 Thread GitBox
madrob commented on pull request #196: URL: https://github.com/apache/solr/pull/196#issuecomment-870027164 How are you arriving at the resulting changes after removing some of the files? For example, in the original PR, the changes to DeleteBackupCmd seem pretty uninteresting but they don'