[GitHub] [solr] madrob commented on pull request #216: SOLR-15535: remove rawtypes warnings in 'grouping' code

2021-08-18 Thread GitBox
madrob commented on pull request #216: URL: https://github.com/apache/solr/pull/216#issuecomment-901424731 I think this is ok to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [solr] madrob commented on pull request #216: SOLR-15535: remove rawtypes warnings in 'grouping' code

2021-07-20 Thread GitBox
madrob commented on pull request #216: URL: https://github.com/apache/solr/pull/216#issuecomment-882803411 I tried to mess around with this a bit by creating a wrapping class, but couldn't get it to work very cleanly so let's stick with this approach and maybe can revisit in the future. Th

[GitHub] [solr] madrob commented on pull request #216: SOLR-15535: remove rawtypes warnings in 'grouping' code

2021-07-20 Thread GitBox
madrob commented on pull request #216: URL: https://github.com/apache/solr/pull/216#issuecomment-882803411 I tried to mess around with this a bit by creating a wrapping class, but couldn't get it to work very cleanly so let's stick with this approach and maybe can revisit in the future. Th

[GitHub] [solr] madrob commented on pull request #216: SOLR-15535: remove rawtypes warnings in 'grouping' code

2021-07-19 Thread GitBox
madrob commented on pull request #216: URL: https://github.com/apache/solr/pull/216#issuecomment-882803411 I tried to mess around with this a bit by creating a wrapping class, but couldn't get it to work very cleanly so let's stick with this approach and maybe can revisit in the future. Th