[GitHub] [solr] madrob commented on pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

madrob commented on pull request #243: URL: https://github.com/apache/solr/pull/243#issuecomment-893768746 > fieldNames and fieldLabels are not copied via the copy constructor, nor via clone and merge probably should handle that here -- This is an automated message from the Apache

[GitHub] [solr] madrob commented on pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

madrob commented on pull request #243: URL: https://github.com/apache/solr/pull/243#issuecomment-892961555 This LGTM, @cpoerschke did you have thoughts on additional documentation around this change? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [solr] madrob commented on pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

madrob commented on pull request #243: URL: https://github.com/apache/solr/pull/243#issuecomment-892961555 This LGTM, @cpoerschke did you have thoughts on additional documentation around this change? -- This is an automated message from the Apache Git Service. To respond to the message,