[GitHub] [solr] marcosfpr commented on a change in pull request #228: SOLR-15496 LTRRescorer unnecessarily (re)creates Comparator

2021-07-21 Thread GitBox
marcosfpr commented on a change in pull request #228: URL: https://github.com/apache/solr/pull/228#discussion_r674040410 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java ## @@ -131,31 +146,12 @@ public TopDocs rescore(IndexSearcher searcher, TopDocs

[GitHub] [solr] marcosfpr commented on a change in pull request #228: SOLR-15496 LTRRescorer unnecessarily (re)creates Comparator

2021-07-20 Thread GitBox
marcosfpr commented on a change in pull request #228: URL: https://github.com/apache/solr/pull/228#discussion_r673383681 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java ## @@ -131,31 +146,12 @@ public TopDocs rescore(IndexSearcher searcher, TopDocs

[GitHub] [solr] marcosfpr commented on a change in pull request #228: SOLR-15496 LTRRescorer unnecessarily (re)creates Comparator

2021-07-20 Thread GitBox
marcosfpr commented on a change in pull request #228: URL: https://github.com/apache/solr/pull/228#discussion_r673372216 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java ## @@ -53,6 +53,21 @@ public LTRRescorer(LTRScoringQuery scoringQuery) { th

[GitHub] [solr] marcosfpr commented on a change in pull request #228: SOLR-15496 LTRRescorer unnecessarily (re)creates Comparator

2021-07-20 Thread GitBox
marcosfpr commented on a change in pull request #228: URL: https://github.com/apache/solr/pull/228#discussion_r673372216 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java ## @@ -53,6 +53,21 @@ public LTRRescorer(LTRScoringQuery scoringQuery) { th