[GitHub] [solr] mkhludnev commented on pull request #1274: SOLR-16611: fix collapse hint=top_fc bug

2023-01-08 Thread GitBox
mkhludnev commented on PR #1274: URL: https://github.com/apache/solr/pull/1274#issuecomment-1374786401 Hi, @metapox I run tests myself. Failures seem unrelated to the change. Please confirm I put your name correctly in CHANGES. I'll merge then. -- This is an automated message from the

[GitHub] [solr] mkhludnev commented on pull request #1274: SOLR-16611: fix collapse hint=top_fc bug

2023-01-07 Thread GitBox
mkhludnev commented on PR #1274: URL: https://github.com/apache/solr/pull/1274#issuecomment-1374441218 @metapox , how I can attribute your contribution in CHANGES.txt? Please give your name or desired login. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [solr] mkhludnev commented on pull request #1274: SOLR-16611: fix collapse hint=top_fc bug

2023-01-07 Thread GitBox
mkhludnev commented on PR #1274: URL: https://github.com/apache/solr/pull/1274#issuecomment-1374440931 Thanks, @metapox. Your test is great. The issue is sometimes a change causes failures in other quite unexpected tests, and it goes to urgent fixes after a merge. So, I really appreciate

[GitHub] [solr] mkhludnev commented on pull request #1274: SOLR-16611: fix collapse hint=top_fc bug

2023-01-06 Thread GitBox
mkhludnev commented on PR #1274: URL: https://github.com/apache/solr/pull/1274#issuecomment-1374073171 @metapox can you confirm that you run tests? Pls put to comment the failed ones. Just to double check before merge. Appreciate your effort! -- This is an automated message from the A