[GitHub] [solr] mlbiscoc commented on a diff in pull request #1627: SOLR-16273: Prometheus Metric Exporter is very slow when collecting large amounts of sample data

2023-06-09 Thread via GitHub
mlbiscoc commented on code in PR #1627: URL: https://github.com/apache/solr/pull/1627#discussion_r1224493642 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/collector/MetricSamples.java: ## @@ -71,4 +83,8 @@ public List asList() { .filter(value -> !value

[GitHub] [solr] mlbiscoc commented on a diff in pull request #1627: SOLR-16273: Prometheus Metric Exporter is very slow when collecting large amounts of sample data

2023-06-09 Thread via GitHub
mlbiscoc commented on code in PR #1627: URL: https://github.com/apache/solr/pull/1627#discussion_r1224493642 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/collector/MetricSamples.java: ## @@ -71,4 +83,8 @@ public List asList() { .filter(value -> !value

[GitHub] [solr] mlbiscoc commented on a diff in pull request #1627: SOLR-16273: Prometheus Metric Exporter is very slow when collecting large amounts of sample data

2023-05-12 Thread via GitHub
mlbiscoc commented on code in PR #1627: URL: https://github.com/apache/solr/pull/1627#discussion_r1192578929 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/collector/MetricSamples.java: ## @@ -47,7 +65,8 @@ public void addSampleIfMetricExists( return;

[GitHub] [solr] mlbiscoc commented on a diff in pull request #1627: SOLR-16273: Prometheus Metric Exporter is very slow when collecting large amounts of sample data

2023-05-12 Thread via GitHub
mlbiscoc commented on code in PR #1627: URL: https://github.com/apache/solr/pull/1627#discussion_r1192417543 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/collector/MetricSamples.java: ## @@ -19,24 +19,42 @@ import io.prometheus.client.Collector; import jav