[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1063434858 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: > I don't think this should require documenting

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1062117703 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: `SolrCores` is a concrete class . I'm against ma

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r106196 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: > There is no change of responsibilities here.

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1060317489 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: As we are making `SolrCores` pluggable, we need

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1060317489 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: As we are making `SolrCores` pluggable, we need

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1059974999 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: I'm seeing a new pluggable component as follows

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1059974999 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: I'm seeing a new pluggable component as follows

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1059845087 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: you mean there is a case for both `` **and** a

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1059804725 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: honestly , a `CoreFactory` is a better abstracti

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1051743360 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: TBH , I do not understand this abstraction.