[GitHub] [solr] noblepaul commented on a diff in pull request #1585: Use Zookeeper persistent recursive Zookeeper watches

2023-05-28 Thread via GitHub
noblepaul commented on code in PR #1585: URL: https://github.com/apache/solr/pull/1585#discussion_r1208801000 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -368,10 +368,152 @@ private StatefulCollectionWatch compute( BiFunction

[GitHub] [solr] noblepaul commented on a diff in pull request #1585: Use Zookeeper persistent recursive Zookeeper watches

2023-05-28 Thread via GitHub
noblepaul commented on code in PR #1585: URL: https://github.com/apache/solr/pull/1585#discussion_r1208800892 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -326,14 +326,14 @@ private boolean updateDocCollection(String collection, DocCol

[GitHub] [solr] noblepaul commented on a diff in pull request #1585: Use Zookeeper persistent recursive Zookeeper watches

2023-05-15 Thread via GitHub
noblepaul commented on code in PR #1585: URL: https://github.com/apache/solr/pull/1585#discussion_r1193817402 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -368,10 +368,152 @@ private StatefulCollectionWatch compute( BiFunction

[GitHub] [solr] noblepaul commented on a diff in pull request #1585: Use Zookeeper persistent recursive Zookeeper watches

2023-05-11 Thread via GitHub
noblepaul commented on code in PR #1585: URL: https://github.com/apache/solr/pull/1585#discussion_r1191951328 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -368,10 +368,152 @@ private StatefulCollectionWatch compute( BiFunction

[GitHub] [solr] noblepaul commented on a diff in pull request #1585: Use Zookeeper persistent recursive Zookeeper watches

2023-05-11 Thread via GitHub
noblepaul commented on code in PR #1585: URL: https://github.com/apache/solr/pull/1585#discussion_r1191949973 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -368,10 +368,152 @@ private StatefulCollectionWatch compute( BiFunction