[GitHub] [solr] psalagnac commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-06-30 Thread GitBox
psalagnac commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-871614788 Hi @gerlowskija, The PR is updated with new class layer. I tried to align to existing implementation for CSG. All classes are now in package `org.apache.solr.s3`. I ke

[GitHub] [solr] psalagnac commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-06-29 Thread GitBox
psalagnac commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-869802855 Hey @gerlowskija, Sorry for the late answer here. Thanks for you feedback. I think we reached an agreement to keep`BlobIndexInput` and remove the abstraction of the generi

[GitHub] [solr] psalagnac commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-06-28 Thread GitBox
psalagnac commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-869802855 Hey @gerlowskija, Sorry for the late answer here. Thanks for you feedback. I think we reached an agreement to keep`BlobIndexInput` and remove the abstraction of the generi

[GitHub] [solr] psalagnac commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-06-10 Thread GitBox
psalagnac commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-858766473 Thanks for all you feedback on this PR @gerlowskija > What distinguishes a few of the I/O classes in this PR (e.g. BlobIndexInput) from existing alternatives (e.g. BufferedC