[GitHub] [solr] psalagnac commented on pull request #1761: SOLR-16879: add queue for expensive admin operations

2023-08-09 Thread via GitHub
psalagnac commented on PR #1761: URL: https://github.com/apache/solr/pull/1761#issuecomment-1671353210 > Any thoughts on how this bug slipped by our notice? I was unable to write a unit that actually do an expensive operation (backup or restore). The low-level queue mechanism is well

[GitHub] [solr] psalagnac commented on pull request #1761: SOLR-16879: add queue for expensive admin operations

2023-08-07 Thread via GitHub
psalagnac commented on PR #1761: URL: https://github.com/apache/solr/pull/1761#issuecomment-1667510102 Hi @dsmiley, I think this change is now ready to be merged. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [solr] psalagnac commented on pull request #1761: SOLR-16879: add queue for expensive admin operations

2023-08-03 Thread via GitHub
psalagnac commented on PR #1761: URL: https://github.com/apache/solr/pull/1761#issuecomment-1664769445 While testing this internally, I found a minor issue (will push a fix soon). The flag to set some operation as expensive is not correctly passed. I'd rather we wait more before merging.