[GitHub] [solr] rahulgoswami commented on a diff in pull request #1816: SOLR-16360: Atomic update on boolean fields doesn't reflect when value starts with "1", "t" or "T"

2023-08-07 Thread via GitHub
rahulgoswami commented on code in PR #1816: URL: https://github.com/apache/solr/pull/1816#discussion_r1286246589 ## solr/core/src/java/org/apache/solr/schema/BoolField.java: ## @@ -211,7 +212,7 @@ public List createFields(SchemaField field, Object value) { @Override publi

[GitHub] [solr] rahulgoswami commented on a diff in pull request #1816: SOLR-16360: Atomic update on boolean fields doesn't reflect when value starts with "1", "t" or "T"

2023-08-06 Thread via GitHub
rahulgoswami commented on code in PR #1816: URL: https://github.com/apache/solr/pull/1816#discussion_r1285342351 ## solr/core/src/java/org/apache/solr/schema/BoolField.java: ## @@ -211,7 +212,7 @@ public List createFields(SchemaField field, Object value) { @Override publi

[GitHub] [solr] rahulgoswami commented on a diff in pull request #1816: SOLR-16360: Atomic update on boolean fields doesn't reflect when value starts with "1", "t" or "T"

2023-08-06 Thread via GitHub
rahulgoswami commented on code in PR #1816: URL: https://github.com/apache/solr/pull/1816#discussion_r1285342351 ## solr/core/src/java/org/apache/solr/schema/BoolField.java: ## @@ -211,7 +212,7 @@ public List createFields(SchemaField field, Object value) { @Override publi

[GitHub] [solr] rahulgoswami commented on a diff in pull request #1816: SOLR-16360: Atomic update on boolean fields doesn't reflect when value starts with "1", "t" or "T"

2023-08-04 Thread via GitHub
rahulgoswami commented on code in PR #1816: URL: https://github.com/apache/solr/pull/1816#discussion_r1284525393 ## solr/core/src/test/org/apache/solr/schema/BooleanFieldTest.java: ## @@ -17,6 +17,7 @@ package org.apache.solr.schema; +import java.util.Map; import org.apach