[GitHub] [solr] risdenk commented on a diff in pull request #1279: SOLR-16613: CryptoKeys should handle RSA padding for OpenJ9

2023-01-09 Thread GitBox
risdenk commented on code in PR #1279: URL: https://github.com/apache/solr/pull/1279#discussion_r1064728436 ## solr/core/src/java/org/apache/solr/util/CryptoKeys.java: ## @@ -295,15 +304,28 @@ public PublicKey getPublicKey() { return publicKey; } -public byte[]

[GitHub] [solr] risdenk commented on a diff in pull request #1279: SOLR-16613: CryptoKeys should handle RSA padding for OpenJ9

2023-01-09 Thread GitBox
risdenk commented on code in PR #1279: URL: https://github.com/apache/solr/pull/1279#discussion_r1064711398 ## solr/core/src/java/org/apache/solr/util/CryptoKeys.java: ## @@ -295,15 +304,28 @@ public PublicKey getPublicKey() { return publicKey; } -public byte[]

[GitHub] [solr] risdenk commented on a diff in pull request #1279: SOLR-16613: CryptoKeys should handle RSA padding for OpenJ9

2023-01-06 Thread GitBox
risdenk commented on code in PR #1279: URL: https://github.com/apache/solr/pull/1279#discussion_r1063768185 ## solr/core/src/test/org/apache/solr/cloud/TestRSAKeyPair.java: ## @@ -36,26 +38,29 @@ public void testGenKeyPair() throws Exception { public void testReadKeysFromDisk