[GitHub] [solr] risdenk commented on a diff in pull request #1545: Update dependencies com.adobe.testing:s3mock-junit4 to v2.12.2 and org.springframework.boot:spring-boot to 2.7.12

2023-06-09 Thread via GitHub
risdenk commented on code in PR #1545: URL: https://github.com/apache/solr/pull/1545#discussion_r1224247241 ## solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java: ## @@ -228,9 +228,20 @@ default void copyIndexFileFrom( * Delete {@code files} at {

[GitHub] [solr] risdenk commented on a diff in pull request #1545: Update dependencies com.adobe.testing:s3mock-junit4 to v2.12.2 and org.springframework.boot:spring-boot to 2.7.12

2023-06-08 Thread via GitHub
risdenk commented on code in PR #1545: URL: https://github.com/apache/solr/pull/1545#discussion_r1223467406 ## solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java: ## @@ -228,9 +228,20 @@ default void copyIndexFileFrom( * Delete {@code files} at {

[GitHub] [solr] risdenk commented on a diff in pull request #1545: Update dependencies com.adobe.testing:s3mock-junit4 to v2.12.2 and org.springframework.boot:spring-boot to 2.7.12

2023-06-08 Thread via GitHub
risdenk commented on code in PR #1545: URL: https://github.com/apache/solr/pull/1545#discussion_r1223433923 ## solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java: ## @@ -228,9 +228,20 @@ default void copyIndexFileFrom( * Delete {@code files} at {

[GitHub] [solr] risdenk commented on a diff in pull request #1545: Update dependencies com.adobe.testing:s3mock-junit4 to v2.12.2 and org.springframework.boot:spring-boot to 2.7.12

2023-06-08 Thread via GitHub
risdenk commented on code in PR #1545: URL: https://github.com/apache/solr/pull/1545#discussion_r1223146361 ## versions.props: ## @@ -71,7 +71,7 @@ org.osgi:osgi.annotation=8.1.0 org.quicktheories:quicktheories=0.26 org.semver4j:semver4j=4.3.0 org.slf4j:*=2.0.7 -org.springfra