[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275292151 integration test is actually working - see failure in https://github.com/apache/solr/pull/1066 and this PR here builds on https://github.com/apache/solr/pull/1066 and fixes it -- This is

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275281453 `SOLR_SERVER_DIR="/opt/solr-${SOLR_VERSION}/server" \` added to handle Jetty home looking at canonical path -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275260913 > I remember rubbing into this with @markrmiller i think we left a comment in the security policy about it? don't see a comment in there. but the issue is `/opt/solr` vs `/opt/solr-10

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275219606 Error running locally `./gradlew -p solr/docker testDocker`: ``` java.security.AccessControlException: access denied ("java.io.FilePermission" "/opt/solr-10.0.0-SNAPSHOT/server/star

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275090735 The docker test failure gave no details :) ``` 2022-10-11T17:27:59.2856817Z > Task :solr:docker:dockerBuild UP-TO-DATE 2022-10-11T17:28:01.2858986Z 2022-10-11T17:28:01.2860970

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275021455 Thanks @dsmiley and @madrob for prompting for an integration test. My fix didn't work and was found by integration tests after fixing the security policy. I'm pushing up a change soon buildi

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1274992957 Created https://issues.apache.org/jira/browse/SOLR-16457 and https://github.com/apache/solr/pull/1066 -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1274972996 > So solr.data.home needs to be set or we need to figure out how to unset it completely to ensure that the security policy doesn't think "" is ok. I think I found the bug in `bin/solr`

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1274956428 wow so I tracked this down to a potentially really ugly security policy bug... https://github.com/apache/solr/blob/main/solr/server/etc/security.policy#L199 ``` permission ja

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1274833300 I don't know how to test this w/ BATS - since we have mixed security policies in build dirs :/ I don't know which security policy rule is allowing this to work in the tests. I would guess in

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1274710727 Well @madrob thanks for the pointer - weirdly https://github.com/apache/solr/blob/main/solr/packaging/test/test_modules.bats#L35 doesn't fail. I would expect it to :( I'll keep digging.

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-05 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1265664893 I'm out for a few weeks due to personal reasons - I would be grateful if someone can help push this a little further. If not I'll look at it when I get back to things. -- This is an autom