risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1303860976
backport to branch_9x here: https://github.com/apache/solr/pull/1161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1296329111
I think this is good to go. Just need to do follow up on branch_9x after
this is merged and backported to branch_9x
--
This is an automated message from the Apache Git Service.
To respond
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1295129586
`./gradlew check -Pvalidation.errorprone=true` passed with changes pushed so
far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1295087385
@dsmiley / @janhoy I think I addressed your concerns so far. The only one
not addressed (yet) is only for branch_9x to add upgrade notes and opting out
of solrj-streaming.
--
This is an a
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1295084688
removed hsqldb and sql module from solrj core. both solrj core and solrj
streaming tests pass. Rerunning the whole test suite now.
--
This is an automated message from the Apache Git Servi
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1295074740
Added a note to solrj refguide for solrj-streaming.
```
git grep -F hsql | grep -Fv -e 'solr/solrj-streaming'
NOTICE.txt:HSQL Database (HSQLDB): http://hsqldb.org/
NOTICE.txt:L
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1295006402
> I assume this is the PR that will stay in main branch, since there is no
dependency added in solrj's build.gradle to depend on solrj-streaming?
@janhoy yes - will add to branch_9x li
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294361637
@joel-bernstein I don't see you listed here
https://github.com/orgs/apache/teams/solr-committers/members?query=joel - its a
private list if you are on it you can see it. I see your username
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294043754
@joel-bernstein I'd do that separately on branch_9x only - similar to
https://github.com/apache/solr/commit/80889178990369617bb5edb0b284ad24e34d5ad3
--
This is an automated message from th
