risdenk commented on PR #1832: URL: https://github.com/apache/solr/pull/1832#issuecomment-1671908610
> "false sense of security" thing false sense of security - My poor wording since we are working around security manager. I mean that we shouldn't even run the tests at all. Disabling the security manager for tests and saying "hey look on JDK 20 on Mac tests pass" but we just hide the fact that we disable the default enabled security manager just to make tests pass seems wrong. I would prefer if we didn't even run any tests or at least fail loudly and say Mac OS X + JDK 20 is unsupported or something like that. I don't have anything in mind about bin/solr or other smarter ways to potentially make the user aware of this. I'm just not a fan of trying to make the tests pass just to make the tests pass. They are failing because JDK 20 + Mac + Jetty + security manager is broken - which is the default out of the box config for Solr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
