risdenk commented on pull request #553:
URL: https://github.com/apache/solr/pull/553#issuecomment-1044604844
@madrob / @dsmiley I think I've resolved all the comments for this. Hadoop
3.3.2 still hasn't been released. I think it would be better to get this merged
in for 9.0 and handle the
risdenk commented on pull request #553:
URL: https://github.com/apache/solr/pull/553#issuecomment-1037254994
So I pushed changes that address most of the review comments so far. There
is a big change that helps alleviate future Hadoop dependency issues. This uses
the `hadoop-client-api`, `
risdenk commented on pull request #553:
URL: https://github.com/apache/solr/pull/553#issuecomment-1037254994
So I pushed changes that address most of the review comments so far. There
is a big change that helps alleviate future Hadoop dependency issues. This uses
the `hadoop-client-api`, `
risdenk commented on pull request #553:
URL: https://github.com/apache/solr/pull/553#issuecomment-1035162389
So been working through the reviews and cleaning up some changes:
* Removed HADOOP-15681 workaround based on comment from @madrob in the jira
* Enabled test that was disabled du
risdenk commented on pull request #553:
URL: https://github.com/apache/solr/pull/553#issuecomment-1026217867
Now that SOLR-14660 has been merged - working on cleaning this up. I put it
back in draft for now.
--
This is an automated message from the Apache Git Service.
To respond to the m
risdenk commented on pull request #553:
URL: https://github.com/apache/solr/pull/553#issuecomment-1022521366
@dsmiley agree about trying to reduce dependencies, but at the same time
`transitive=false` requires a whole bunch of knowledge about how the code is
being used. I think it makes se
risdenk commented on pull request #553:
URL: https://github.com/apache/solr/pull/553#issuecomment-1021461272
@madrob think I addressed your concerns. Removed copy of `HttpServer2` since
not needed anymore, updated `package-info.java` and fixed comment.
@janhoy still working on `Do yo
risdenk commented on pull request #553:
URL: https://github.com/apache/solr/pull/553#issuecomment-1018189921
I need to review the `check` output and fix any license file issues. I
figured it made sense to get this reviewed early - especially by @dsmiley with
the dependency/transitive chang
