[GitHub] [solr] stillalex commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

stillalex commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1059544372 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java: ## @@ -1041,6 +1052,15 @@ public HttpSolrClient build() { if (this.invariantParams.

[GitHub] [solr] stillalex commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

stillalex commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058956658 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -128,7 +128,7 @@ public class Http2SolrClient extends SolrClient { private static

[GitHub] [solr] stillalex commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

stillalex commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058699692 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -128,7 +128,7 @@ public class Http2SolrClient extends SolrClient { private static

[GitHub] [solr] stillalex commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

stillalex commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058609508 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -128,7 +128,7 @@ public class Http2SolrClient extends SolrClient { private static

[GitHub] [solr] stillalex commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

stillalex commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058496938 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -991,6 +992,7 @@ public static class Builder { private ExecutorService executor

[GitHub] [solr] stillalex commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

stillalex commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058496938 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -991,6 +992,7 @@ public static class Builder { private ExecutorService executor

[GitHub] [solr] stillalex commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

stillalex commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058496493 ## solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java: ## @@ -138,19 +138,19 @@ public UpdateShardHandler(UpdateShardHandlerConfig cfg) { HttpCli