[GitHub] [solr] stillalex commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-02-03 Thread via GitHub
stillalex commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1416106834 thank you @epugh! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [solr] stillalex commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-25 Thread via GitHub
stillalex commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1404046037 makes sense, thanks for the update @epugh! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [solr] stillalex commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-25 Thread via GitHub
stillalex commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1404022543 @epugh gentle ping. are we good to merge, or is there something that needs more work? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [solr] stillalex commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
stillalex commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400790967 > Sure! I can buy that. So... leave the todo? It otherwise looks good to merge. yep, leave the todo. there is only that string matching issue in the combo which I don't know how to

[GitHub] [solr] stillalex commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
stillalex commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400705981 > How hard would it be to change the query to submit when you click the button? Are there other places we link to the schema analysis page and have it auto run, so that requiring a button

[GitHub] [solr] stillalex commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
stillalex commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400620486 > Maybe we don't need the default value if we just show the page, but don't submit it to the backend, which then avoids the error message. I agree with this idea, but the way the

[GitHub] [solr] stillalex commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
stillalex commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400615323 > I see the ? from the bool... I was trying to figure out if there is something we could put there, like "Bool" or something? But regardless, I like how this works... I would keep

[GitHub] [solr] stillalex commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-19 Thread GitBox
stillalex commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1397746600 @epugh please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific