[GitHub] [solr] stillalex commented on pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context

2023-03-07 Thread via GitHub
stillalex commented on PR #1410: URL: https://github.com/apache/solr/pull/1410#issuecomment-1459013554 thank you @dsmiley, really appreciate your help on getting this merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [solr] stillalex commented on pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context

2023-03-06 Thread via GitHub
stillalex commented on PR #1410: URL: https://github.com/apache/solr/pull/1410#issuecomment-1457520914 I think all feedback was covered -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [solr] stillalex commented on pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context

2023-03-03 Thread via GitHub
stillalex commented on PR #1410: URL: https://github.com/apache/solr/pull/1410#issuecomment-1453570691 deadlock avoided by setting corePoolSzize to 3. thanks @risdenk! waiting for test results but PR should be open for review again. -- This is an automated message from the Apache Git Serv

[GitHub] [solr] stillalex commented on pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context

2023-03-02 Thread via GitHub
stillalex commented on PR #1410: URL: https://github.com/apache/solr/pull/1410#issuecomment-1452711234 trying the `ShardHandlerFactory#sizeOfQueue` setting on a Solr 9 definitely shows some weirdness, I'm unable to create a collection: ``` 2023-03-02 15:15:40.028 INFO (qtp2048013503-2

[GitHub] [solr] stillalex commented on pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context

2023-03-02 Thread via GitHub
stillalex commented on PR #1410: URL: https://github.com/apache/solr/pull/1410#issuecomment-1452676506 @dsmiley good news and bad news :) I finally managed to add tests (and cover failure scenarios too) thanks for the pointers, I was tempted to not go the extra mile. now the not so great