[GitHub] [solr] stillalex commented on pull request #1484: SOLR-11685: use INVALID_STATE for ZK state issue in DistributedZkUpdateProcessor

2023-08-02 Thread via GitHub
stillalex commented on PR #1484: URL: https://github.com/apache/solr/pull/1484#issuecomment-1663248841 > I'd like to commit it as it is, marking it as an "improvement". WDYT @stillalex ? I agree to commit. I also dropped the ball here, but if time permits I would still like to revisi

[GitHub] [solr] stillalex commented on pull request #1484: SOLR-11685: use INVALID_STATE for ZK state issue in DistributedZkUpdateProcessor

2023-04-12 Thread via GitHub
stillalex commented on PR #1484: URL: https://github.com/apache/solr/pull/1484#issuecomment-1505877485 I would like to revisit one of the changes here, the `Request says it is coming from parent shard leader but we are in active state` flow. I am looking at this from the ShardSplitTest fail

[GitHub] [solr] stillalex commented on pull request #1484: SOLR-11685: use INVALID_STATE for ZK state issue in DistributedZkUpdateProcessor

2023-04-04 Thread via GitHub
stillalex commented on PR #1484: URL: https://github.com/apache/solr/pull/1484#issuecomment-1496284849 for shard split testing we have ShardSplitTest, but it's rather flaky. I am trying to unpack the failures in the effort of getting it more stable #1504 it does simple things: split shard +