[GitHub] [solr] stillalex commented on pull request #1884: SOLR-16955 Tracing v2 apis breaks SecurityConfHandler

2023-09-06 Thread via GitHub
stillalex commented on PR #1884: URL: https://github.com/apache/solr/pull/1884#issuecomment-1709444570 I sat on this a bit and realized I would prefer adding a test to 9.x backport and ended up rewriting it so it fits with 9.x constructs. makes me feel a tiny bit more confident that this re

[GitHub] [solr] stillalex commented on pull request #1884: SOLR-16955 Tracing v2 apis breaks SecurityConfHandler

2023-09-06 Thread via GitHub
stillalex commented on PR #1884: URL: https://github.com/apache/solr/pull/1884#issuecomment-1709046355 thank you @dsmiley for the continued review, I am getting ready to merge. one more aspect of this is the backport to 9.x. it will be extremely complicated to take the test as is. one eas

[GitHub] [solr] stillalex commented on pull request #1884: SOLR-16955 Tracing v2 apis breaks SecurityConfHandler

2023-09-02 Thread via GitHub
stillalex commented on PR #1884: URL: https://github.com/apache/solr/pull/1884#issuecomment-1703906815 more changes! - added 'ops' tag (name can be changed of course). SecurityConfHandler will publish the list of operations as a list. - reduced user tag data to principal name only. I

[GitHub] [solr] stillalex commented on pull request #1884: SOLR-16955 Tracing v2 apis breaks SecurityConfHandler

2023-09-02 Thread via GitHub
stillalex commented on PR #1884: URL: https://github.com/apache/solr/pull/1884#issuecomment-1703898337 poking some more at the test I found the following interesting bit: the 'db.user' does a Principal#toString resulting in the following. this might be too much info to share in the telemetr