stillalex commented on PR #1954:
URL: https://github.com/apache/solr/pull/1954#issuecomment-1741816116
looks good to me. left a few minor notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
stillalex commented on PR #1954:
URL: https://github.com/apache/solr/pull/1954#issuecomment-1741811853
the gradle precommit build is unhappy about something. did you already take
a look at that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
stillalex commented on PR #1954:
URL: https://github.com/apache/solr/pull/1954#issuecomment-1734414823
re. this pattern of parsing `user:password`
```
if (credentials != null && credentials.indexOf(":") > 0) {
String[] credentialsArray = credentials.split(":");
```
