stillalex opened a new pull request, #1705: URL: https://github.com/apache/solr/pull/1705
https://issues.apache.org/jira/browse/SOLR-16841 Proposing some benchmarks for the various QueryResponseWriter options Running benchmark ``` ./jmh.sh QueryResponseWriters ``` Running benchmark for a specific type ``` ./jmh.sh QueryResponseWriters -p wt=javabin ``` Some numbers ``` Benchmark (wt) Mode Cnt Score Error Units QueryResponseWriters.query javabin thrpt 4 3102.964 ± 40.186 ops/s QueryResponseWriters.query json thrpt 4 450.379 ± 27.369 ops/s QueryResponseWriters.query smile thrpt 4 3572.251 ± 17.695 ops/s QueryResponseWriters.query xml thrpt 4 369.158 ± 17.062 ops/s QueryResponseWriters.query python thrpt 4 370.970 ± 17.421 ops/s QueryResponseWriters.query phps thrpt 4 455.651 ± 21.930 ops/s QueryResponseWriters.query ruby thrpt 4 402.097 ± 20.994 ops/s QueryResponseWriters.query raw thrpt 4 448.895 ± 14.736 ops/s QueryResponseWriters.query cbor thrpt 4 2326.908 ± 122.610 ops/s ``` very interesting how 'smile' is above 'javabin'? and json is ~7 times slower than javabin. really wondering if this is not skewed by accident <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the approach taken to implement your solution. # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org