[GitHub] [solr] telendt commented on pull request #1051: SOLR-13219: Fix NPE in FieldLengthFeature with non-stored/missing fields

2022-10-06 Thread GitBox
telendt commented on PR #1051: URL: https://github.com/apache/solr/pull/1051#issuecomment-1270566970 If would be wonderful if it could go to 9.1.0, that way we could probably skip patching ourselves (we need that in the place were I work). Either way, thank you for the review! -- This is

[GitHub] [solr] telendt commented on pull request #1051: SOLR-13219: Fix NPE in FieldLengthFeature with non-stored/missing fields

2022-10-06 Thread GitBox
telendt commented on PR #1051: URL: https://github.com/apache/solr/pull/1051#issuecomment-1270551866 Does it look right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [solr] telendt commented on pull request #1051: SOLR-13219: Fix NPE in FieldLengthFeature with non-stored/missing fields

2022-10-06 Thread GitBox
telendt commented on PR #1051: URL: https://github.com/apache/solr/pull/1051#issuecomment-1270548332 Sure, can do. What's the rule? Should I put my name and yours as the reviewer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [solr] telendt commented on pull request #1051: SOLR-13219: Fix NPE in FieldLengthFeature with non-stored/missing fields

2022-09-30 Thread GitBox
telendt commented on PR #1051: URL: https://github.com/apache/solr/pull/1051#issuecomment-1263766897 @cpoerschke: I would really appreciate if you could review this one as the original author of the code. -- This is an automated message from the Apache Git Service. To respond to the messa