Re: [GitHub] [solr] tflobbe commented on pull request #1931: SOLR-16978: Be case insensitive when parsing booleans from text

2023-09-19 Thread Eric Pugh
I wonder if we should strive to be consistent (in either lenient mode or strict mode) through out Solr? For example, I noticed that the AuthTool does a check for "true" or "false" with some custom code. If we said that on, off, etc are all valid choices, then we could support that through ou

[GitHub] [solr] tflobbe commented on pull request #1931: SOLR-16978: Be case insensitive when parsing booleans from text

2023-09-18 Thread via GitHub
tflobbe commented on PR #1931: URL: https://github.com/apache/solr/pull/1931#issuecomment-1724631857 @gerlowskija Any thoughts here? I'm on the fence. I don't really love the leniency with which we are reading boolean params here, it seems more useful for configuration files than it is for