[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on PR #96: URL: https://github.com/apache/solr/pull/96#issuecomment-1726362729 I think that is everything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on PR #96: URL: https://github.com/apache/solr/pull/96#issuecomment-1726208757 I think I've fixed the things called out, but I might have missed something. I don't use GitHub very often. Let me know if I left something unresolved. It all looks good to me, thanks

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on PR #96: URL: https://github.com/apache/solr/pull/96#issuecomment-1721846297 Just updated the docs. When circuit breakers are enabled for update requests, how does that work for replicas? Can an NRT replica get out of sync by rejecting a request? It should be

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on PR #96: URL: https://github.com/apache/solr/pull/96#issuecomment-1721706717 The documentation says " A user may register multiple circuit breakers of the same type with different thresholds for each request type." That is a future feature, right? I'll delete that fo

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on PR #96: URL: https://github.com/apache/solr/pull/96#issuecomment-1699585220 @janhoy Thanks so much for picking this up. I'll take a look at the compromise. This is a tricky decision, changing behavior to match the documentation. Is it a breaking change or not

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on PR #96: URL: https://github.com/apache/solr/pull/96#issuecomment-1687150222 > On Jun 2, 2023, at 1:41 AM, Jan Høydahl ***@***.***> wrote: > @wrunderwood , @atris , it's a shame that this fine PR was aband

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-859667485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries ab

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853410595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries ab

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853452250 I apologize for the personal comment. The documentation and name describe a CPU utilization circuit breaker. The implementation is a load average metric. Load average is not

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853410595 Anyone running this on a multi-CPU machine should disable it immediately. The documentation says it will reject traffic when total CPU usage reaches a limit, but it will real

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-853347376 That is what this patch does, move the existing behavior to a load average circuit breaker and create a new CPU usage circuit breaker. Combining the two has a problem. The ra

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-849021275 The existing CPU circuit breaker has an incorrect name, so yes, it is moved to a more accurate name. Load average can include things besides CPU. In some systems, it includes