[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-18 Thread GitBox
HoustonPutman commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690739265 ## File path: controllers/util/solr_util.go ## @@ -601,6 +552,11 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *solr.S

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-17 Thread GitBox
HoustonPutman commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690739575 ## File path: controllers/solrcloud_controller.go ## @@ -364,51 +364,57 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (ctrl.Resu

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-17 Thread GitBox
HoustonPutman commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690739265 ## File path: controllers/util/solr_util.go ## @@ -601,6 +552,11 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *solr.S