Re: [PR] [SOLR-17368] Change prometheus dummy metric to a more unique label [solr]

2024-08-03 Thread via GitHub
dsmiley merged PR #2613: URL: https://github.com/apache/solr/pull/2613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] [SOLR-17368] Change prometheus dummy metric to a more unique label [solr]

2024-08-02 Thread via GitHub
mlbiscoc commented on PR #2613: URL: https://github.com/apache/solr/pull/2613#issuecomment-2265399024 Yes, on `main` branch it fails the same way when running Jetty based tests next to it. From Chris's suggestion, `./gradlew -p solr/core test -Ptests.jvms=1 -Ptests.verbose=true --tests Test

Re: [PR] [SOLR-17368] Change prometheus dummy metric to a more unique label [solr]

2024-08-01 Thread via GitHub
dsmiley commented on PR #2613: URL: https://github.com/apache/solr/pull/2613#issuecomment-2264580162 Were you able to reproduce the problem? If I understand the cause, you'd need to run a number of tests, not just this one test. The root fix would be to stop metric leaks between tests!

Re: [PR] [SOLR-17368] Change prometheus dummy metric to a more unique label [solr]

2024-08-01 Thread via GitHub
mlbiscoc commented on code in PR #2613: URL: https://github.com/apache/solr/pull/2613#discussion_r1701057393 ## solr/core/src/test/org/apache/solr/response/TestPrometheusResponseWriter.java: ## @@ -78,7 +78,12 @@ public void testPrometheusStructureOutput() throws Exception {