Re: [PR] [SOLR-17368] TestPrometheusResponseWriter redesign [solr]

2024-07-30 Thread via GitHub
dsmiley merged PR #2586: URL: https://github.com/apache/solr/pull/2586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] [SOLR-17368] TestPrometheusResponseWriter redesign [solr]

2024-07-24 Thread via GitHub
mlbiscoc commented on PR #2586: URL: https://github.com/apache/solr/pull/2586#issuecomment-2248429857 > > any leaking metrics from other metrics should not override these values. > > That's dodging an issue that should be investigated as it might interfere with another metrics based t

Re: [PR] [SOLR-17368] TestPrometheusResponseWriter redesign [solr]

2024-07-23 Thread via GitHub
dsmiley commented on PR #2586: URL: https://github.com/apache/solr/pull/2586#issuecomment-2246415444 > any leaking metrics from other metrics should not override these values. That's dodging an issue that should be investigated as it might interfere with another metrics based test I

Re: [PR] [SOLR-17368] TestPrometheusResponseWriter redesign [solr]

2024-07-23 Thread via GitHub
dsmiley commented on code in PR #2586: URL: https://github.com/apache/solr/pull/2586#discussion_r1688787862 ## solr/core/src/test/org/apache/solr/response/TestPrometheusResponseWriter.java: ## @@ -34,57 +38,104 @@ import org.junit.ClassRule; import org.junit.Test; -/** Tests

[PR] [SOLR-17368] TestPrometheusResponseWriter redesign [solr]

2024-07-23 Thread via GitHub
mlbiscoc opened a new pull request, #2586: URL: https://github.com/apache/solr/pull/2586 https://issues.apache.org/jira/browse/SOLR-17368 # Description Please provide a short description of the changes you're making with this pull request. The `TestPrometheus