Re: [PR] Auto-label PRs with labeler action [solr]

2024-01-10 Thread via GitHub
gerlowskija commented on PR #2180: URL: https://github.com/apache/solr/pull/2180#issuecomment-1885127661 Joining this discussion late, but this is really cool. Thanks Jan! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Auto-label PRs with labeler action [solr]

2024-01-10 Thread via GitHub
janhoy commented on PR #2180: URL: https://github.com/apache/solr/pull/2180#issuecomment-1884939027 @alessandrobenedetti Btw since the first iteration is merged already, please open a new PR for your suggestion. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Auto-label PRs with labeler action [solr]

2024-01-10 Thread via GitHub
janhoy commented on PR #2180: URL: https://github.com/apache/solr/pull/2180#issuecomment-1884935856 > I was wondering if it makes sense to add cascade rules that label also depending on the package? That would be nice too. And probably possible due to the folder structure of the sou

Re: [PR] Auto-label PRs with labeler action [solr]

2024-01-10 Thread via GitHub
alessandrobenedetti commented on PR #2180: URL: https://github.com/apache/solr/pull/2180#issuecomment-1884585494 I am late on the train, but I really like this initiative. I've been labelling PRs from time to time, especially to track progress in the vector search space, but I admit I was

Re: [PR] Auto-label PRs with labeler action [solr]

2024-01-10 Thread via GitHub
janhoy commented on PR #2180: URL: https://github.com/apache/solr/pull/2180#issuecomment-1884378319 Thanks, let's adjust with follow-up PRs if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Auto-label PRs with labeler action [solr]

2024-01-10 Thread via GitHub
janhoy merged PR #2180: URL: https://github.com/apache/solr/pull/2180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Auto-label PRs with labeler action [solr]

2024-01-09 Thread via GitHub
janhoy commented on PR #2180: URL: https://github.com/apache/solr/pull/2180#issuecomment-1883196648 > Does prefixing do something special like give you another filter? I don't mind `bats-test` or `example` as a label... No, it's more a convention to namespace different types of tags.

Re: [PR] Auto-label PRs with labeler action [solr]

2024-01-09 Thread via GitHub
epugh commented on PR #2180: URL: https://github.com/apache/solr/pull/2180#issuecomment-1883132692 This is super exciting... I am thinking about other areas of Solr that specific groups of folks might want to monitor, and therefore might want to have a label to cue them. `streaming` is o

Re: [PR] Auto-label PRs with labeler action [solr]

2024-01-09 Thread via GitHub
janhoy commented on PR #2180: URL: https://github.com/apache/solr/pull/2180#issuecomment-1883044999 I changed `tool:docker` to `docker`. Would you prefer plain labels `build` instead of `tool:build` and `scripts` instead of `tool:scripts`? -- This is an automated message from the Apache G

Re: [PR] Auto-label PRs with labeler action [solr]

2024-01-06 Thread via GitHub
dsmiley commented on PR #2180: URL: https://github.com/apache/solr/pull/2180#issuecomment-1879967619 Cool! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Auto-label PRs with labeler action [solr]

2024-01-06 Thread via GitHub
MarcusSorealheis commented on code in PR #2180: URL: https://github.com/apache/solr/pull/2180#discussion_r1443674756 ## .github/workflows/labeler.yml: ## @@ -0,0 +1,12 @@ +name: "Pull Request Labeler" +on: + - pull_request_target + +jobs: + labeler: +permissions: + co

[PR] Auto-label PRs with labeler action [solr]

2024-01-05 Thread via GitHub
janhoy opened a new pull request, #2180: URL: https://github.com/apache/solr/pull/2180 The project has some PR labels defined, but we don't use them because it is boring to manually label things, see https://github.com/apache/solr/pulls This PR implements https://github.com/actions/la