Re: [PR] Cross-DC: Get tests passing and checker cleanup. [solr]

HoustonPutman merged PR #2541: URL: https://github.com/apache/solr/pull/2541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

Re: [PR] Cross-DC: Get tests passing and checker cleanup. [solr]

HoustonPutman commented on PR #2541: URL: https://github.com/apache/solr/pull/2541#issuecomment-2229188195 Ok I've addressed your comments, thanks! I've added a line for the windows thing -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Cross-DC: Get tests passing and checker cleanup. [solr]

HoustonPutman commented on code in PR #2541: URL: https://github.com/apache/solr/pull/2541#discussion_r1678270283 ## solr/modules/cross-dc/src/test-files/configs/cloud-minimal.zip: ## Review Comment: Ok, I've added generating it to the gradle build, so it doesn't fall out-

Re: [PR] Cross-DC: Get tests passing and checker cleanup. [solr]

markrmiller commented on PR #2541: URL: https://github.com/apache/solr/pull/2541#issuecomment-2224701112 So I responded to those questions, but since they no longer lined up with the existing code, I didn't know if they were still relevant, so I didn't spend a lot of time investigating. Jus

Re: [PR] Cross-DC: Get tests passing and checker cleanup. [solr]

markrmiller commented on code in PR #2541: URL: https://github.com/apache/solr/pull/2541#discussion_r1675330963 ## solr/cross-dc-manager/src/test/org/apache/solr/crossdc/manager/SimpleSolrIntegrationTest.java: ## @@ -46,21 +45,21 @@ public static void ensureWorkingMockito() {

Re: [PR] Cross-DC: Get tests passing and checker cleanup. [solr]

markrmiller commented on code in PR #2541: URL: https://github.com/apache/solr/pull/2541#discussion_r1675329967 ## solr/cross-dc-manager/src/java/org/apache/solr/crossdc/manager/messageprocessor/SolrMessageProcessor.java: ## @@ -29,345 +33,369 @@ import org.apache.solr.common.c

Re: [PR] Cross-DC: Get tests passing and checker cleanup. [solr]

markrmiller commented on code in PR #2541: URL: https://github.com/apache/solr/pull/2541#discussion_r1675329123 ## solr/modules/cross-dc/src/test-files/configs/cloud-minimal.zip: ## Review Comment: I guess it depends on what you mean by "need". At the most basic level, I o

Re: [PR] Cross-DC: Get tests passing and checker cleanup. [solr]

markrmiller commented on PR #2541: URL: https://github.com/apache/solr/pull/2541#issuecomment-2224680147 So I tried this out on Windows today, and I still get the same issue. Maybe we can conditionally disable the test policy for this module for Windows? > It appears as if your JD

Re: [PR] Cross-DC: Get tests passing and checker cleanup. [solr]

markrmiller commented on PR #2541: URL: https://github.com/apache/solr/pull/2541#issuecomment-2219344405 I didn't get to this today, but will respond and test out on windows tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Cross-DC: Get tests passing and checker cleanup. [solr]

HoustonPutman commented on code in PR #2541: URL: https://github.com/apache/solr/pull/2541#discussion_r1657812390 ## solr/cross-dc-manager/src/test/org/apache/solr/crossdc/manager/SimpleSolrIntegrationTest.java: ## @@ -46,21 +45,21 @@ public static void ensureWorkingMockito() {