dsmiley merged PR #2405:
URL: https://github.com/apache/solr/pull/2405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mlbiscoc commented on code in PR #2405:
URL: https://github.com/apache/solr/pull/2405#discussion_r1644646280
##
solr/solr-ref-guide/modules/deployment-guide/pages/monitoring-with-prometheus-and-grafana.adoc:
##
@@ -587,3 +594,27 @@ This screenshot shows what it might look like:
mlbiscoc commented on code in PR #2405:
URL: https://github.com/apache/solr/pull/2405#discussion_r1644645966
##
solr/core/src/java/org/apache/solr/metrics/prometheus/node/SolrNodeHandlerMetric.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mlbiscoc commented on PR #2405:
URL: https://github.com/apache/solr/pull/2405#issuecomment-2176364062
> I'd like to suggest an integration test showing all the output (say to a
file) stripped of numbers (to remove brittle/changing stuff) to show that we
export what we mean to export. I
dsmiley commented on code in PR #2405:
URL: https://github.com/apache/solr/pull/2405#discussion_r1641064461
##
solr/core/src/java/org/apache/solr/metrics/prometheus/jvm/SolrJvmBuffersMetric.java:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
mlbiscoc commented on PR #2405:
URL: https://github.com/apache/solr/pull/2405#issuecomment-2161412631
Added ref-guide documentation on Prometheus endpoint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mlbiscoc commented on PR #2405:
URL: https://github.com/apache/solr/pull/2405#issuecomment-2159031117
> It doesn't feel right to merge this PR right now. Needs docs. Also the
choice of what metrics are done so far is inverted from the value that would
make most sense for this whole
