rseitz commented on PR #2404:
URL: https://github.com/apache/solr/pull/2404#issuecomment-2083646456
I opened a separate PR here: https://github.com/apache/solr/pull/2429
Basically, it's a one-line change that updates another
`_parser.buildRequestFrom()` call inside `EmbeddedSolrServer.req
epugh commented on PR #2404:
URL: https://github.com/apache/solr/pull/2404#issuecomment-2082948170
I think open a seperate PR, just to keep the one that was merged and
committed seperate from a new one. I'd love to see the suggested PR... Do we
also need a test there?
--
This is an au
rseitz commented on PR #2404:
URL: https://github.com/apache/solr/pull/2404#issuecomment-2082885569
Thanks @epugh and @dsmiley for the feedback and support for this fix. I'll
open a separate ticket for the security.json refactor and tag Eric.
There is a minor followup I would like to
epugh commented on PR #2404:
URL: https://github.com/apache/solr/pull/2404#issuecomment-2082388354
Thanks @rseitz for the contribution. Tag me on the `security.json`
refactor please!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
epugh merged PR #2404:
URL: https://github.com/apache/solr/pull/2404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
rseitz commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r158126
##
solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformerDistrib.java:
##
@@ -61,22 +75,51 @@ public static void setupCluster() throws Exception {
rseitz commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r158126
##
solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformerDistrib.java:
##
@@ -61,22 +75,51 @@ public static void setupCluster() throws Exception {
rseitz commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r1568077123
##
solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformerDistrib.java:
##
@@ -61,22 +75,51 @@ public static void setupCluster() throws Exception {
rseitz commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r1580195804
##
solr/core/src/java/org/apache/solr/response/transform/SubQueryAugmenterFactory.java:
##
@@ -340,7 +346,9 @@ public void transform(SolrDocument doc, int docid) {
fin
rseitz commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r1580121540
##
solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java:
##
@@ -252,7 +260,11 @@ private SolrQueryRequest buildRequestFrom(
new SolrQueryRequestBase(
rseitz commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r1580121540
##
solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java:
##
@@ -252,7 +260,11 @@ private SolrQueryRequest buildRequestFrom(
new SolrQueryRequestBase(
rseitz commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r1580121540
##
solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java:
##
@@ -252,7 +260,11 @@ private SolrQueryRequest buildRequestFrom(
new SolrQueryRequestBase(
dsmiley commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r1578800441
##
solr/core/src/java/org/apache/solr/response/transform/SubQueryAugmenterFactory.java:
##
@@ -340,7 +346,9 @@ public void transform(SolrDocument doc, int docid) {
fi
rseitz commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r1568088624
##
solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java:
##
@@ -215,8 +215,9 @@ public NamedList request(SolrRequest request,
String coreName)
rseitz commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r1568077123
##
solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformerDistrib.java:
##
@@ -61,22 +75,51 @@ public static void setupCluster() throws Exception {
epugh commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r1568013748
##
solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java:
##
@@ -215,8 +215,9 @@ public NamedList request(SolrRequest request,
String coreName)
rseitz opened a new pull request, #2404:
URL: https://github.com/apache/solr/pull/2404
https://issues.apache.org/jira/browse/SOLR-12813
# Description
This PR fixes an issue where subqueries don't work when basic auth is
enabled. The problem surfaces when 2 or more shards are in
17 matches
Mail list logo
