HoustonPutman commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2455058672
Yes, that is absolutely related, but I thoroughly tested that before
pushing 🙄 I'll take a look.
--
This is an automated message from the Apache Git Service.
To respond to the mess
iamsanjay commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2452823185
Thanks @HoustonPutman,
Do you think this one also related?
TestPullReplicaErrorHandling#testCloseHooksDeletedOnReconnect
--
This is an automated message from the Apache Git Service.
HoustonPutman commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2452633368
@iamsanjay , this was a small race condition waiting for the connection to
come back. I added a wait, since I don't think this is what the test was
intending to test. Commit: 0f8decddaa1
iamsanjay commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2451302759
Possibility of relating to this one.
Build scan data https://ge.apache.org/s/63ya5yavjnh5o
> Error from server at http://127.0.0.1:43991/solr: Cannot talk to ZooKeeper
- Updates a
HoustonPutman merged PR #760:
URL: https://github.com/apache/solr/pull/760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
HoustonPutman commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2448378316
Well apparently actually using PRS breaks a good amount of things
lovely. I'm going to undo that, and just add a `@NoPRS` tag to the test.
--
This is an automated message from the
HoustonPutman commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2448299251
For some reason this PR breaks
`TestPullReplicaErrorHandling.testCloseHooksDeletedOnReconnect()` on a seed
that makes PRS enabled by default. From what I can tell there is an error in
`
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1821119914
##
solr/solrj-zookeeper/build.gradle:
##
@@ -37,6 +37,13 @@ dependencies {
implementation 'org.apache.httpcomponents:httpclient'
implementation 'org.apache.h
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1821092572
##
solr/solrj-zookeeper/build.gradle:
##
@@ -37,6 +37,13 @@ dependencies {
implementation 'org.apache.httpcomponents:httpclient'
implementation 'org.apache.h
dsmiley commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1819655529
##
solr/solrj-zookeeper/build.gradle:
##
@@ -37,6 +37,13 @@ dependencies {
implementation 'org.apache.httpcomponents:httpclient'
implementation 'org.apache.httpcom
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1819484898
##
solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/BadClusterTest.java:
##
@@ -97,15 +102,15 @@ private void testAllNodesDown() throws Exception {
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1819481659
##
solr/solrj-zookeeper/build.gradle:
##
@@ -37,6 +37,13 @@ dependencies {
implementation 'org.apache.httpcomponents:httpclient'
implementation 'org.apache.h
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1819446921
##
solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/BadClusterTest.java:
##
@@ -97,15 +102,15 @@ private void testAllNodesDown() throws Exception {
dsmiley commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1817969516
##
solr/core/src/java/org/apache/solr/cloud/ZkShardTerms.java:
##
@@ -431,7 +424,7 @@ private void registerWatcher() throws KeeperException {
};
try {
/
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1817369402
##
solr/test-framework/build.gradle:
##
@@ -43,6 +43,17 @@ dependencies {
var zkExcludes = {
exclude group: "org.apache.yetus", module: "audience-annotations"
dsmiley commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1815068705
##
gradle/testing/randomization/policies/solr-tests.policy:
##
@@ -50,6 +50,7 @@ grant {
permission java.net.SocketPermission "127.0.0.1:4", "connect,resolve";
permiss
dsmiley commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1815061933
##
solr/solrj-zookeeper/build.gradle:
##
@@ -32,6 +32,13 @@ dependencies {
implementation project(':solr:solrj')
+api('org.apache.curator:curator-client', {
Re
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1813486856
##
solr/core/src/java/org/apache/solr/cloud/ZkShardTerms.java:
##
@@ -398,16 +397,6 @@ private void retryRegisterWatcher() {
return;
} catch (KeeperExc
HoustonPutman commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2433255117
Ok, I might leave the `retry` refactoring for another PR. I think this one
is good to go. Let's merge and do follow up PRs accordingly.
--
This is an automated message from the Apache
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1813019223
##
solr/core/src/java/org/apache/solr/cloud/ZkShardTerms.java:
##
@@ -398,16 +397,6 @@ private void retryRegisterWatcher() {
return;
} catch (KeeperExc
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1811506520
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -366,7 +361,6 @@ public ZkController(
.withUrl(zkServerAddress)
.withTim
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1811505686
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -1187,25 +1178,19 @@ private void createEphemeralLiveNode() throws
KeeperException, InterruptedEx
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1811503866
##
solr/core/src/java/org/apache/solr/cloud/ZkDistributedQueue.java:
##
@@ -246,24 +246,19 @@ public byte[] remove() throws NoSuchElementException,
KeeperException, I
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1811502050
##
solr/core/src/java/org/apache/solr/cloud/ZkShardTerms.java:
##
@@ -398,16 +397,6 @@ private void retryRegisterWatcher() {
return;
} catch (KeeperExc
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1811495054
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -791,7 +792,14 @@ public void expireZkSession(JettySolrRunner jetty) {
Core
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1811493394
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/SolrZkClient.java:
##
@@ -1048,6 +1125,11 @@ public void downloadFromZK(String zkPath, Path dir)
throws
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1811488646
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/SolrZkClient.java:
##
@@ -993,14 +1051,33 @@ public void updateACLs(final String root) throws
KeeperExce
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1811484721
##
solr/solrj-zookeeper/build.gradle:
##
@@ -32,6 +32,13 @@ dependencies {
implementation project(':solr:solrj')
+api('org.apache.curator:curator-client',
HoustonPutman commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2430374181
A little past summer, but it's time to get this in.
I merged with main. Next up is to get rid of the back-compat APIs I kept
since this was targeting 9x at first.
--
This is an
HoustonPutman commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2085509862
Thanks for putting in the work @risdenk ! I will push to add this for 10x
only this summer.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
risdenk commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2085355210
> This is an important initiative. If you've given up on it @risdenk, let us
know so someone can take over.
I'm not actively working on it. @HoustonPutman started this and I just tried
dsmiley commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2077904166
This is an important initiative. If you've given up on it @risdenk, let us
know so someone can take over.
--
This is an automated message from the Apache Git Service.
To respond to the mess
dsmiley commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1520372343
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -1187,25 +1178,19 @@ private void createEphemeralLiveNode() throws
KeeperException, InterruptedExcept
risdenk commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-1989244863
@HoustonPutman @dsmiley I'm happy to merge main into this again and resolve
any conflicts. can you do another review to make sure all is good before
merging to main?
--
This is an automated
HoustonPutman commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-1989013704
Yeah let's get this in main. Probably best to not introduce it in a late 9x
version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
dsmiley commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-1988385713
AFAIK, ever since #1743 landed, we're no longer blocked on Hadoop-Auth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
epugh commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-1987317773
It would be a shame if this never makes it in Should hadoop-auth be
removed in 10x? Or moved to it's own github project in 10x?
--
This is an automated message from the Apache Git Se
github-actions[bot] commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-1987015802
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify the
risdenk commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1357066251
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/SolrZkClient.java:
##
@@ -138,82 +143,82 @@ private SolrZkClient(
return;
}
this.zkServerAddre
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1356982674
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/SolrZkClient.java:
##
@@ -138,82 +143,82 @@ private SolrZkClient(
return;
}
this.zkServe
HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1356972638
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/BeforeReconnect.java:
##
@@ -16,6 +16,17 @@
*/
package org.apache.solr.common.cloud;
-public interfa
risdenk commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-1758409816
@magibney @dsmiley I pushed the revert of retryOnConnLoss - basically its
just ignored now in
[44399c7](https://github.com/apache/solr/pull/760/commits/44399c710f639350c8c635bb3458024699a9c0a5
risdenk commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-1757978274
I can take care of that hopefully today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
magibney commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-1757964761
> I propose we make the loss of the reconnect boolean its own PR, plus the
methods that shielded use of ZkCmdExecutor. That will make this effort here
more independently reviewable and would
epugh commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-1756119133
How come the bats tests didn't run? I notice that only precommit, solr and
solrJ tests run...
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
risdenk commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1352582118
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/BeforeReconnect.java:
##
@@ -16,6 +16,17 @@
*/
package org.apache.solr.common.cloud;
-public interface Bef
risdenk commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-1755464945
I merged main (after hadoop 3.3.6/curator 5.x) and then fixed up different
things after that to get all the tests passing including nightly. Would
appreciate another set of eyes @HoustonPutman
risdenk commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1346588451
##
solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java:
##
@@ -147,125 +154,93 @@ public SolrZkClient(
String zkServerAddress,
int zkClientTimeo
risdenk commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-1747787746
https://github.com/apache/solr/pull/1743 is in main and so this PR should be
ready to update :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please
risdenk commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1344711265
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -794,9 +796,13 @@ public void expireZkSession(JettySolrRunner jetty) {
CoreContai
risdenk commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-1745631852
hadoop 3.3.6 upgraded curator to 5.2.0 -
https://github.com/apache/solr/pull/1743. I'm working on getting that in.
chatted w/ @HoustonPutman about it as well
--
This is an automated message
51 matches
Mail list logo
