Re: [PR] SOLR-16397: Modify v2 'renamecore' API to be more REST-ful [solr]

2023-11-15 Thread via GitHub
gerlowskija commented on PR #2072: URL: https://github.com/apache/solr/pull/2072#issuecomment-1812988417 Thanks again for the PR @iamsanjay ! Really starting to crank through these now - it's awesome! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] SOLR-16397: Modify v2 'renamecore' API to be more REST-ful [solr]

2023-11-15 Thread via GitHub
gerlowskija merged PR #2072: URL: https://github.com/apache/solr/pull/2072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-16397: Modify v2 'renamecore' API to be more REST-ful [solr]

2023-11-14 Thread via GitHub
gerlowskija commented on code in PR #2072: URL: https://github.com/apache/solr/pull/2072#discussion_r1393262795 ## solr/solr-ref-guide/modules/configuration-guide/pages/coreadmin-api.adoc: ## @@ -349,9 +349,19 @@ This parameter is required in v1, and part of the url in the v2 A

Re: [PR] SOLR-16397: Modify v2 'renamecore' API to be more REST-ful [solr]

2023-11-09 Thread via GitHub
iamsanjay commented on code in PR #2072: URL: https://github.com/apache/solr/pull/2072#discussion_r1388302148 ## solr/core/src/test/org/apache/solr/handler/admin/CoreAdminOperationTest.java: ## @@ -167,23 +167,29 @@ public void testRenameUnexpectedFailuresResultIn500SolrExcepti

Re: [PR] SOLR-16397: Modify v2 'renamecore' API to be more REST-ful [solr]

2023-11-09 Thread via GitHub
iamsanjay commented on code in PR #2072: URL: https://github.com/apache/solr/pull/2072#discussion_r1388290890 ## solr/core/src/java/org/apache/solr/handler/admin/CoreAdminOperation.java: ## @@ -172,12 +175,14 @@ public enum CoreAdminOperation implements CoreAdminOp { RENA

Re: [PR] SOLR-16397: Modify v2 'renamecore' API to be more REST-ful [solr]

2023-11-09 Thread via GitHub
iamsanjay commented on code in PR #2072: URL: https://github.com/apache/solr/pull/2072#discussion_r1388289154 ## solr/core/src/java/org/apache/solr/handler/admin/CoreAdminOperation.java: ## @@ -172,12 +175,14 @@ public enum CoreAdminOperation implements CoreAdminOp { RENA

[PR] SOLR-16397: Modify v2 'renamecore' API to be more REST-ful [solr]

2023-11-09 Thread via GitHub
iamsanjay opened a new pull request, #2072: URL: https://github.com/apache/solr/pull/2072 https://issues.apache.org/jira/browse/SOLR-16397 # Description V2(JAX-RS) Endpoints for core admin op "RENAME". # Solution This commit changes the v2 "renamecore"