dsmiley commented on PR #2473:
URL: https://github.com/apache/solr/pull/2473#issuecomment-2136414314
It feel weird to me that we go to ZkStateReader to build node URLs.
Conceptually, this seem like something that ought to exist at a higher
conceptual layer. On the other hand, ZkStateReade
epugh commented on PR #2473:
URL: https://github.com/apache/solr/pull/2473#issuecomment-2127873247
@AndreyBozhko thanks for this. There are some ideas in the comments
including from @gerlowskija that if you want to take and run with, would be
great!
--
This is an automated message from
epugh merged PR #2473:
URL: https://github.com/apache/solr/pull/2473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
gerlowskija commented on code in PR #2473:
URL: https://github.com/apache/solr/pull/2473#discussion_r1611983813
##
solr/solrj/src/java/org/apache/solr/common/util/Utils.java:
##
@@ -716,10 +716,30 @@ public static String applyUrlScheme(final String url,
final String urlScheme)
epugh commented on code in PR #2473:
URL: https://github.com/apache/solr/pull/2473#discussion_r1611519373
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -1331,12 +1331,24 @@ public ConfigData getSecurityProps(boolean getFresh) {
* Ret
AndreyBozhko commented on code in PR #2473:
URL: https://github.com/apache/solr/pull/2473#discussion_r1610734437
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -1331,12 +1331,24 @@ public ConfigData getSecurityProps(boolean getFresh) {
epugh commented on code in PR #2473:
URL: https://github.com/apache/solr/pull/2473#discussion_r1610621573
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -1331,12 +1331,24 @@ public ConfigData getSecurityProps(boolean getFresh) {
* Ret
epugh commented on code in PR #2473:
URL: https://github.com/apache/solr/pull/2473#discussion_r1610274309
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -1331,12 +1331,24 @@ public ConfigData getSecurityProps(boolean getFresh) {
* Ret
AndreyBozhko commented on code in PR #2473:
URL: https://github.com/apache/solr/pull/2473#discussion_r1610156568
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -1331,12 +1331,24 @@ public ConfigData getSecurityProps(boolean getFresh) {
epugh commented on code in PR #2473:
URL: https://github.com/apache/solr/pull/2473#discussion_r1609824037
##
solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java:
##
@@ -572,7 +572,7 @@ private V2Request postPlugin(Object payload) {
public void waitForAllNode
AndreyBozhko opened a new pull request, #2473:
URL: https://github.com/apache/solr/pull/2473
https://issues.apache.org/jira/browse/SOLR-16659
# Description
Update codebase to use methods that directly construct V2 urls instead of
doing substring replacement on a V1 url.
AndreyBozhko commented on code in PR #2473:
URL: https://github.com/apache/solr/pull/2473#discussion_r1609001401
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java:
##
@@ -374,7 +374,7 @@ protected HttpRequestBase createMethod(SolrRequest
request, Stri
12 matches
Mail list logo
