Re: [PR] SOLR-16824: Backport single dash arguments migration [solr]

2024-08-10 Thread via GitHub
epugh merged PR #2618: URL: https://github.com/apache/solr/pull/2618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-16824: Backport single dash arguments migration [solr]

2024-08-10 Thread via GitHub
epugh commented on PR #2618: URL: https://github.com/apache/solr/pull/2618#issuecomment-2281633658 Thanks @janhoy for speaking up. I will merge to `branch_9x` then only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] SOLR-16824: Backport single dash arguments migration [solr]

2024-08-10 Thread via GitHub
janhoy commented on PR #2618: URL: https://github.com/apache/solr/pull/2618#issuecomment-2281573636 +1 good work. No big problem if some CLI work spills over to 9.8 or 9.9. Some of the changes her may be seen as pure bug fixes to get behavior align with documentation. It is not goo

Re: [PR] SOLR-16824: Backport single dash arguments migration [solr]

2024-08-10 Thread via GitHub
epugh commented on PR #2618: URL: https://github.com/apache/solr/pull/2618#issuecomment-2281484502 Okay, I've been starting at this PR for a few days now, and I believe that it is all correct, that all of these changes make sense in the `branch_9x` line. I sort of think this should go in

Re: [PR] SOLR-16824: Backport single dash arguments migration [solr]

2024-08-09 Thread via GitHub
malliaridis commented on PR #2618: URL: https://github.com/apache/solr/pull/2618#issuecomment-2278075274 The bats test succeed on my machine now with Java 17 and the latest changes. I can't reproduce the error anymore from the automation. -- This is an automated message from the Apache Gi

[PR] SOLR-16824: Backport single dash arguments migration [solr]

2024-08-06 Thread via GitHub
malliaridis opened a new pull request, #2618: URL: https://github.com/apache/solr/pull/2618 https://issues.apache.org/jira/browse/SOLR-16824 # Description Various code fragments are only available in `branch_9X` and require separate migration. # Solution This PR a