Re: [PR] SOLR-16825: Generate v2 API SolrRequest bindings [solr]

2024-05-08 Thread via GitHub
dsmiley commented on code in PR #1793: URL: https://github.com/apache/solr/pull/1793#discussion_r1594858131 ## solr/solrj/build.gradle: ## @@ -85,3 +94,73 @@ dependencies { testImplementation 'org.apache.commons:commons-lang3' testImplementation 'io.dropwizard.metrics:metr

Re: [PR] SOLR-16825: Generate v2 API SolrRequest bindings [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on code in PR #1793: URL: https://github.com/apache/solr/pull/1793#discussion_r1588028324 ## solr/solrj/build.gradle: ## @@ -85,3 +94,73 @@ dependencies { testImplementation 'org.apache.commons:commons-lang3' testImplementation 'io.dropwizard.metric

Re: [PR] SOLR-16825: Generate v2 API SolrRequest bindings [solr]

2024-04-26 Thread via GitHub
dsmiley commented on code in PR #1793: URL: https://github.com/apache/solr/pull/1793#discussion_r1581719562 ## solr/solrj/build.gradle: ## @@ -85,3 +94,73 @@ dependencies { testImplementation 'org.apache.commons:commons-lang3' testImplementation 'io.dropwizard.metrics:metr

Re: [PR] SOLR-16825: Generate v2 API SolrRequest bindings [solr]

2024-04-26 Thread via GitHub
dsmiley commented on PR #1793: URL: https://github.com/apache/solr/pull/1793#issuecomment-2080334301 Quoting me: > At least the use of Jackson is optional. Which is to say, if there is a client that is just doing index/query then it need not include our new "api" module either I h