Re: [PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-29 Thread via GitHub
gerlowskija merged PR #2079: URL: https://github.com/apache/solr/pull/2079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-29 Thread via GitHub
gerlowskija commented on PR #2079: URL: https://github.com/apache/solr/pull/2079#issuecomment-1832327048 Alright- I'm going to merge in our "approximation" for now and use it to dogfood the generated Python client over in #1681. If anyone has any more feedback on this, lmk and we can

Re: [PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-17 Thread via GitHub
gerlowskija commented on PR #2079: URL: https://github.com/apache/solr/pull/2079#issuecomment-1817197921 Progress! I was able to make some tweaks to the Java interfaces the generate the OAS and clients so that users can specify their query JSON a few different ways in the generated clients

Re: [PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-16 Thread via GitHub
gerlowskija commented on PR #2079: URL: https://github.com/apache/solr/pull/2079#issuecomment-1815173502 > I suspect that many people will craft their JSON independent of the JS code or Python code, like via some string replacement, and then just pass it in. Yeah, I imagine that is po

Re: [PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-16 Thread via GitHub
epugh commented on PR #2079: URL: https://github.com/apache/solr/pull/2079#issuecomment-1814899779 Definitly referring to the JSON DSL. I suspect that many people will craft their JSON independent of the JS code or Python code, like via some string replacement, and then just pass it in...

Re: [PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-16 Thread via GitHub
gerlowskija commented on PR #2079: URL: https://github.com/apache/solr/pull/2079#issuecomment-1814728136 > Our Admin UI handling of /select covers almost ever property so probably couldn't use the JS version. Yep definitely. The "approximation" in this PR falls pretty far short of what

Re: [PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-15 Thread via GitHub
janhoy commented on PR #2079: URL: https://github.com/apache/solr/pull/2079#issuecomment-1813475510 > Would that be easier to approximate? I've been thinking about how to approach that part. Whether we can model each and every feature in the JSON DSL, such as query parsers, attributes

Re: [PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-15 Thread via GitHub
epugh commented on PR #2079: URL: https://github.com/apache/solr/pull/2079#issuecomment-1813427350 interesting idea! Our Admin UI handling of /select covers almost ever property so probably couldn't use the JS version.. However, for the V2 Query syntax, is that actually simpler from a A

Re: [PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-15 Thread via GitHub
gerlowskija commented on PR #2079: URL: https://github.com/apache/solr/pull/2079#issuecomment-1813217851 This PR was motivated primarily by the desire to "dogfood" the Python client we're looking to generate in #1681. We have limited Python code in our repo, and very little of the code we

[PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-15 Thread via GitHub
gerlowskija opened a new pull request, #2079: URL: https://github.com/apache/solr/pull/2079 https://issues.apache.org/jira/browse/SOLR-16835 # Description Now that Solr uses its OAS to generate client bindings in multiple languages (Java and JavaScript, with Python coming s