Re: [PR] SOLR-17044: Expose api "version" on SolrRequest objects [solr]

2024-09-05 Thread via GitHub
gerlowskija commented on PR #2456: URL: https://github.com/apache/solr/pull/2456#issuecomment-2332526264 Circling back to this now that many of the file-store APIs have been converted to JAX-RS and the nicer fix for PackageToolTest is now do-able. I've switched a bit of GSR usage over

Re: [PR] SOLR-17044: Expose api "version" on SolrRequest objects [solr]

2024-08-19 Thread via GitHub
github-actions[bot] commented on PR #2456: URL: https://github.com/apache/solr/pull/2456#issuecomment-2297718520 This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please t

Re: [PR] SOLR-17044: Expose api "version" on SolrRequest objects [solr]

2024-05-13 Thread via GitHub
epugh commented on PR #2456: URL: https://github.com/apache/solr/pull/2456#issuecomment-2108467589 > Yeah - there's a lot, **a lot** of GSR usage that's only there because folks want to us an API that isn't covered in SolrJ. > > IMO there's still some valid usecases for keeping GSR ar

Re: [PR] SOLR-17044: Expose api "version" on SolrRequest objects [solr]

2024-05-13 Thread via GitHub
gerlowskija commented on PR #2456: URL: https://github.com/apache/solr/pull/2456#issuecomment-2107298420 Yeah - there's a lot, **a lot** of GSR usage that's only there because an API folks want to use isn't covered in SolrJ. IMO there's still some valid usecases for keeping GSR around

Re: [PR] SOLR-17044: Expose api "version" on SolrRequest objects [solr]

2024-05-12 Thread via GitHub
epugh commented on PR #2456: URL: https://github.com/apache/solr/pull/2456#issuecomment-2106273308 From my perspective, GSR is the wrong way to think about a generic interaction.. It has all the overhead and complexity of our SolrJ apis, but without any of the nice typing, helping you craf

Re: [PR] SOLR-17044: Expose api "version" on SolrRequest objects [solr]

2024-05-10 Thread via GitHub
gerlowskija commented on PR #2456: URL: https://github.com/apache/solr/pull/2456#issuecomment-2105176277 PackageToolTest currently fails with this PR, due to some quirky GenericSolrRequest usage in the PackageTool and PackageUtils code. It'd take a bit of untangling, but is do-able to fix.

[PR] SOLR-17044: Expose api "version" on SolrRequest objects [solr]

2024-05-10 Thread via GitHub
gerlowskija opened a new pull request, #2456: URL: https://github.com/apache/solr/pull/2456 https://issues.apache.org/jira/browse/SOLR-17044 # Description SolrJ often needs to know whether a given request is for a v1 or v2 API, but doesn't have an easy way to do so. The be