dsmiley merged PR #2474:
URL: https://github.com/apache/solr/pull/2474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dsmiley commented on PR #2474:
URL: https://github.com/apache/solr/pull/2474#issuecomment-2141246716
And another hang in another of my PRs:
https://github.com/apache/solr/pull/2487#issuecomment-2141245307
Looking forward to merging this today/Friday :-) and not waiting *that*
long
dsmiley commented on PR #2474:
URL: https://github.com/apache/solr/pull/2474#issuecomment-2135435742
If I get no more feedback, I'll merge Friday.
I'm not sure what single test (or small number of such) to beast. Running
all tests isn't viable.
Suggested CHANGES.txt in "Bugs":
epugh commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1611734387
##
solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java:
##
@@ -93,69 +87,69 @@ public class CoreContainerProvider implements
ServletContextListener {
epugh commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1611732329
##
solr/test-framework/src/java/org/apache/solr/embedded/JettySolrRunner.java:
##
@@ -375,24 +370,11 @@ private void init(int port) {
new
dsmiley commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1611685627
##
solr/test-framework/src/java/org/apache/solr/embedded/JettySolrRunner.java:
##
@@ -556,15 +528,7 @@ public synchronized void start(boolean reusePort) throws
Exception
dsmiley commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1611670535
##
solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java:
##
@@ -93,69 +87,69 @@ public class CoreContainerProvider implements
ServletContextListener {
dsmiley commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1610784556
##
solr/core/src/test/org/apache/solr/handler/admin/HealthCheckHandlerTest.java:
##
@@ -112,36 +112,6 @@ public void testHealthCheckHandler() throws Exception {
dsmiley commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1610783362
##
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:
##
@@ -73,10 +72,7 @@
public class SolrDispatchFilter extends BaseSolrFilter implements
dsmiley commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1610765299
##
solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java:
##
@@ -93,69 +87,69 @@ public class CoreContainerProvider implements
ServletContextListener {
dsmiley commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1610754549
##
solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java:
##
@@ -93,69 +87,69 @@ public class CoreContainerProvider implements
ServletContextListener {
gus-asf commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1609936991
##
solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java:
##
@@ -93,69 +87,69 @@ public class CoreContainerProvider implements
ServletContextListener {
gus-asf commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1609932690
##
solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java:
##
@@ -93,69 +87,69 @@ public class CoreContainerProvider implements
ServletContextListener {
gus-asf commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1609932690
##
solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java:
##
@@ -93,69 +87,69 @@ public class CoreContainerProvider implements
ServletContextListener {
gus-asf commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1609909368
##
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:
##
@@ -73,10 +72,7 @@
public class SolrDispatchFilter extends BaseSolrFilter implements
dsmiley commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1609237802
##
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:
##
@@ -167,8 +158,10 @@ public void init(FilterConfig config) throws
ServletException {
}
dsmiley opened a new pull request, #2474:
URL: https://github.com/apache/solr/pull/2474
Thereby fixing some rare bugs in tests, maybe in the real world too.
https://issues.apache.org/jira/browse/SOLR-17118
--
This is an automated message from the Apache Git Service.
To respond to
17 matches
Mail list logo
