Re: [PR] SOLR-17119: Exception swallowing in ContainerPluginsApi causes some config validation errors to be ignored [solr]

2024-01-24 Thread via GitHub
dsmiley merged PR #2202: URL: https://github.com/apache/solr/pull/2202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SOLR-17119: Exception swallowing in ContainerPluginsApi causes some config validation errors to be ignored [solr]

2024-01-24 Thread via GitHub
ycallea commented on code in PR #2202: URL: https://github.com/apache/solr/pull/2202#discussion_r1464959226 ## solr/CHANGES.txt: ## @@ -140,6 +140,9 @@ Improvements * SOLR-17096: solr.xml now supports declaring clusterSingleton plugins (Paul McArthur, David Smiley) +*

Re: [PR] SOLR-17119: Exception swallowing in ContainerPluginsApi causes some config validation errors to be ignored [solr]

2024-01-23 Thread via GitHub
dsmiley commented on code in PR #2202: URL: https://github.com/apache/solr/pull/2202#discussion_r1463627890 ## solr/CHANGES.txt: ## @@ -140,6 +140,9 @@ Improvements * SOLR-17096: solr.xml now supports declaring clusterSingleton plugins (Paul McArthur, David Smiley) +*

Re: [PR] SOLR-17119: Exception swallowing in ContainerPluginsApi causes some config validation errors to be ignored [solr]

2024-01-23 Thread via GitHub
ycallea commented on PR #2202: URL: https://github.com/apache/solr/pull/2202#issuecomment-1906160411 > Can a CHANGES.txt entry be proposed here? I suppose this is an "Improvement", though I can sympathize why you filed the JIRA issue as a bug. I agree classifying it as a bug could be

Re: [PR] SOLR-17119: Exception swallowing in ContainerPluginsApi causes some config validation errors to be ignored [solr]

2024-01-19 Thread via GitHub
dsmiley commented on PR #2202: URL: https://github.com/apache/solr/pull/2202#issuecomment-1900824614 Can a CHANGES.txt entry be proposed here? I suppose this is an "Improvement", though I can sympathize why you filed the JIRA issue as a bug. -- This is an automated message from the

Re: [PR] SOLR-17119: Exception swallowing in ContainerPluginsApi causes some config validation errors to be ignored [solr]

2024-01-19 Thread via GitHub
ycallea commented on code in PR #2202: URL: https://github.com/apache/solr/pull/2202#discussion_r1458725903 ## solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java: ## @@ -509,6 +541,24 @@ public void m2(SolrQueryRequest req, SolrQueryResponse rsp) { } }

Re: [PR] SOLR-17119: Exception swallowing in ContainerPluginsApi causes some config validation errors to be ignored [solr]

2024-01-19 Thread via GitHub
pvcnt commented on code in PR #2202: URL: https://github.com/apache/solr/pull/2202#discussion_r1458658401 ## solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java: ## @@ -509,6 +541,24 @@ public void m2(SolrQueryRequest req, SolrQueryResponse rsp) { } }

Re: [PR] SOLR-17119: Exception swallowing in ContainerPluginsApi causes some config validation errors to be ignored [solr]

2024-01-19 Thread via GitHub
pvcnt commented on code in PR #2202: URL: https://github.com/apache/solr/pull/2202#discussion_r1458657389 ## solr/core/src/java/org/apache/solr/handler/admin/ContainerPluginsApi.java: ## @@ -134,29 +131,25 @@ public void update(PayloadObj payload) throws IOException { }

Re: [PR] SOLR-17119: Exception swallowing in ContainerPluginsApi causes some config validation errors to be ignored [solr]

2024-01-19 Thread via GitHub
ycallea commented on code in PR #2202: URL: https://github.com/apache/solr/pull/2202#discussion_r1457446395 ## solr/core/src/java/org/apache/solr/handler/admin/ContainerPluginsApi.java: ## @@ -134,29 +131,25 @@ public void update(PayloadObj payload) throws IOException { }

Re: [PR] SOLR-17119: Exception swallowing in ContainerPluginsApi causes some config validation errors to be ignored [solr]

2024-01-18 Thread via GitHub
ycallea commented on code in PR #2202: URL: https://github.com/apache/solr/pull/2202#discussion_r1457446395 ## solr/core/src/java/org/apache/solr/handler/admin/ContainerPluginsApi.java: ## @@ -134,29 +131,25 @@ public void update(PayloadObj payload) throws IOException { }

Re: [PR] SOLR-17119: Exception swallowing in ContainerPluginsApi causes some config validation errors to be ignored [solr]

2024-01-18 Thread via GitHub
pvcnt commented on code in PR #2202: URL: https://github.com/apache/solr/pull/2202#discussion_r1457106803 ## solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java: ## @@ -509,6 +541,24 @@ public void m2(SolrQueryRequest req, SolrQueryResponse rsp) { } }