Re: [PR] SOLR-17150: Create MemAllowedLimit [solr]

2024-09-26 Thread via GitHub
sigram commented on code in PR #2708: URL: https://github.com/apache/solr/pull/2708#discussion_r1777173213 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -382,11 +382,20 @@ This parameter specifies the amount of CPU time, in milliseconds, a

Re: [PR] SOLR-17150: Create MemAllowedLimit [solr]

2024-09-26 Thread via GitHub
sigram commented on code in PR #2708: URL: https://github.com/apache/solr/pull/2708#discussion_r1777168448 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -382,11 +382,20 @@ This parameter specifies the amount of CPU time, in milliseconds, a

Re: [PR] SOLR-17150: Create MemAllowedLimit [solr]

2024-09-26 Thread via GitHub
sigram commented on code in PR #2708: URL: https://github.com/apache/solr/pull/2708#discussion_r1777165905 ## solr/core/src/java/org/apache/solr/search/MemAllowedLimit.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] SOLR-17150: Create MemAllowedLimit [solr]

2024-09-25 Thread via GitHub
gus-asf commented on code in PR #2708: URL: https://github.com/apache/solr/pull/2708#discussion_r1775480324 ## solr/core/src/java/org/apache/solr/search/MemAllowedLimit.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[PR] SOLR-17150: Create MemAllowedLimit [solr]

2024-09-12 Thread via GitHub
sigram opened a new pull request, #2708: URL: https://github.com/apache/solr/pull/2708 This is a refreshed PR using the latest QueryLimit APIs and a thread-safe accumulation of value, similar to the approach in `CpuAllowedLimit`. However, since that class uses a thread-local managed by `Thr