dsmiley merged PR #2363:
URL: https://github.com/apache/solr/pull/2363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #2363:
URL: https://github.com/apache/solr/pull/2363#issuecomment-2030147402
Maybe in this PR or another we'll add a test like you (Mark) describe to
ensure that CloudSolrClient directs requests to Solr in all circumstances
(giving up on smart routing to a core if th
markrmiller commented on PR #2363:
URL: https://github.com/apache/solr/pull/2363#issuecomment-2019851574
Not off hand, but you can likely just create a collection, create a
DocCollection with the state you want, convert it to json with the code that
does that, and then overwrite cluster sta
dsmiley commented on PR #2363:
URL: https://github.com/apache/solr/pull/2363#issuecomment-2019808827
I was aware we may just be moving to a new problem, albeit a situation that
is even more rare than what we have today. @markrmiller can you recommend a
specific test or a way to make a test
markrmiller commented on PR #2363:
URL: https://github.com/apache/solr/pull/2363#issuecomment-2017601379
I'd be careful removing all the waits in tests without some pretty thorough
testing in some slow environments - for one, it's a bandaid rather than a fix,
there is still a race, it's jus
dsmiley commented on PR #2363:
URL: https://github.com/apache/solr/pull/2363#issuecomment-2016364187
Proposed CHANGES.txt under 9.6 Bug Fix:
> CloudSolrClient and Solr could in rare circumstances report that a
collection does not exist right after it was actually just created (an
eventua
aparnasuresh85 commented on code in PR #2363:
URL: https://github.com/apache/solr/pull/2363#discussion_r1536189971
##
solr/core/src/test/org/apache/solr/cloud/AliasIntegrationTest.java:
##
@@ -99,17 +99,6 @@ public void testProperties() throws Exception {
CollectionAdminReq
dsmiley commented on code in PR #2363:
URL: https://github.com/apache/solr/pull/2363#discussion_r1536097875
##
solr/core/src/test/org/apache/solr/cloud/AliasIntegrationTest.java:
##
@@ -99,17 +99,6 @@ public void testProperties() throws Exception {
CollectionAdminRequest.cr
aparnasuresh85 commented on PR #2363:
URL: https://github.com/apache/solr/pull/2363#issuecomment-2015349982
> > The reason I did not make the logic consistent across both providers is
because BaseHttpClusterStateProvider, where the logic for getState() is
implemented for the http version, c
dsmiley commented on code in PR #2363:
URL: https://github.com/apache/solr/pull/2363#discussion_r1535589661
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ClusterStateProvider.java:
##
@@ -52,8 +52,7 @@ static ClusterStateProvider newZkClusterStateProvider(
/**
aparnasuresh85 commented on PR #2363:
URL: https://github.com/apache/solr/pull/2363#issuecomment-2014026536
> I'm glad to see the logic that was in V2HttpCall made more common (move to
base class) as it should not have been specific to V2. Perhaps my oversight 6
years ago.
>
> Updati
aparnasuresh85 commented on PR #2363:
URL: https://github.com/apache/solr/pull/2363#issuecomment-2013499876
> I'm glad to see the logic that was in V2HttpCall made more common (move to
base class) as it should not have been specific to V2. Perhaps my oversight 6
years ago.
>
> Updati
dsmiley commented on code in PR #2363:
URL: https://github.com/apache/solr/pull/2363#discussion_r1534052101
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -345,6 +348,41 @@ protected void init() throws Exception {
action = PASSTHROUGH;
}
+ /**
13 matches
Mail list logo
