epugh merged PR #2412:
URL: https://github.com/apache/solr/pull/2412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
laminelam commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2067730797
> I noticed that you have this listed as a 10 change, not a 9.6.. which is
fine by me, just wanted to check...
My bad... I put it first in 9.6 but when resolving conflicts I somehow
epugh commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2067505398
I noticed that you have this listed as a 10 change, not a 9.6.. which is
fine by me, just wanted to check...
--
This is an automated message from the Apache Git Service.
To respond to the m
laminelam commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2067450739
I think the PR is ready for a merge.
Run another full test and all tests passed
Thank you @epugh and @HoustonPutman for your review and feedback.
--
This is an automated message fr
laminelam commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572781910
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -54,17 +54,12 @@ public class CloudHttp2SolrClient extends CloudSolrClient {
laminelam commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572781253
##
solr/core/src/test/org/apache/solr/cli/TestExportTool.java:
##
@@ -218,6 +231,66 @@ public void testVeryLargeCluster() throws Exception {
}
}
+ @Test
+ pu
HoustonPutman commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572758958
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -54,17 +54,12 @@ public class CloudHttp2SolrClient extends CloudSolrClient
epugh commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572740653
##
solr/core/src/test/org/apache/solr/cli/TestExportTool.java:
##
@@ -218,6 +231,66 @@ public void testVeryLargeCluster() throws Exception {
}
}
+ @Test
+ public
laminelam commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2067045033
> > @laminelam should we just merge the other test over to this PR? and then
I can close it...
>
> done :)
BTW, in _testWithBasicAuth_, I used
"_CollectionAdminRequest.create
laminelam commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572722875
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -85,14 +79,62 @@ protected CloudHttp2SolrClient(Builder builder) {
this.lb
laminelam commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2067028284
> @laminelam should we just merge the other test over to this PR? and then I
can close it...
done :)
--
This is an automated message from the Apache Git Service.
To respond to t
epugh commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572697455
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -85,14 +79,62 @@ protected CloudHttp2SolrClient(Builder builder) {
this.lbClie
laminelam commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2066977654
> @laminelam should we just merge the other test over to this PR? and then I
can close it...
Yes I think we should. Will do
--
This is an automated message from the Apache Git Ser
laminelam commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572680652
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -85,14 +79,62 @@ protected CloudHttp2SolrClient(Builder builder) {
this.lb
laminelam commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572678088
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -85,14 +79,62 @@ protected CloudHttp2SolrClient(Builder builder) {
this.lb
epugh commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572623626
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -54,17 +54,12 @@ public class CloudHttp2SolrClient extends CloudSolrClient {
*/
epugh commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2066901677
@laminelam should we just merge the other test over to this PR? and then I
can close it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
17 matches
Mail list logo
